Skip to content

Fix webconfig #11861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
milouse wants to merge 2 commits into from
Closed

Fix webconfig #11861

milouse wants to merge 2 commits into from

Conversation

@milouse
Copy link
Contributor

@milouse milouse commented Oct 2, 2025

Description

Not sure since when, but I just used web_config to refresh my color theme and discovered that it generates some error as universal values.

This MR fix the 2 issues I got:

  • the new underline style behavior make the default False value to be translated to --underline=False, which makes set_color not really happy
  • a probably more old mistake was inside the parse_opt function, which did not support long options separated from their value with an = sign (i.e. --background=red instead of --background red), causing the = sign to be kept as part of the color value, leading after translation to universal variable to a wrong double = sign: --background==red.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed (I may be wrong but I think web_config does not have any test)
  • User-visible changes noted in CHANGELOG.rst (not sure we should document a fix?)

milouse added 2 commits October 2, 2025 13:06
@milouse
web_config: Use None as default for underline style
ebaef9a 
Underline is no more a boolean and should be one of the accepted style,
or None. By keeping False as default value, web_config was generating
wrong --underline=False settings
@milouse
web_config: Support long options separated with = from their value
abcb758
@krobelus krobelus modified the milestones: fish 4.2, fish 4.1.2 Oct 3, 2025
krobelus pushed a commit that referenced this pull request Oct 3, 2025
@milouse @krobelus
web_config: Use None as default for underline style
c884c08 
Underline is no more a boolean and should be one of the accepted style,
or None. By keeping False as default value, web_config was generating
wrong --underline=False settings

Part of #11861
@krobelus krobelus closed this in 8adc598 Oct 3, 2025
krobelus pushed a commit that referenced this pull request Oct 3, 2025
@milouse @krobelus
web_config: Use None as default for underline style
8dd9008 
Underline is no more a boolean and should be one of the accepted style,
or None. By keeping False as default value, web_config was generating
wrong --underline=False settings

Part of #11861

(cherry picked from commit c884c08)
krobelus pushed a commit that referenced this pull request Oct 3, 2025
@milouse @krobelus
web_config: Support long options separated with = from their value
4b6ad75 
Closes #11861

(cherry picked from commit 8adc598)
@milouse milouse deleted the fix-webconfig branch October 6, 2025 09:20
@faho faho mentioned this pull request Oct 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

fish 4.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@milouse @krobelus