Make command run by __fish_echo output to TTY for color detection #11888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, e.g. Alt-L shows the directory entries one per line and without colors.
krobelus
reviewed
Oct 5, 2025
| - Added a workaround for old versions of Zellij where :kbd:`escape` processing was delayed (:issue:`11868`). | ||
| - Fixed a case where the :doc:`web-based configuration tool <cmds/fish_config>` would generate invalid configuration (:issue:`11861`). | ||
| - Fixed a case where upgrading fish would break old versions of fish that were still running. | ||
| - Fix Alt+L binding not formatting ls output correctly (one entry per line, no colors). |
Contributor
There was a problem hiding this comment.
FWIW our nice formatting syntax would be :kbd:ls
| string >&2 repeat -N \n --count=(math (commandline | count) - $line + 1) | ||
| printf %s\n $erase_line($argv) >&2 | ||
| printf %s $erase_line >&2 | ||
| $argv >&2 |
Contributor
There was a problem hiding this comment.
Oof, my bad.
As written, this fails to clear lines beyond the first one. This is
not a problem right now (so it should also be fine to revert
1fdf37c (__fish_echo: fully overwrite lines, 2025-09-17),
because IIRC clearing the first line wasn't needed because fish
already does that. But it can't hurt, so LGTM as is.)
Going forward we should probably clear to end of string here, so \e[J AKA tput ed.
But I'm happy to add that later, only when the fix mentioned in 1fdf37c actually needed.
Contributor
Author
|
Thanks for taking care of that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this, e.g. Alt-L shows the directory entries one per line and without colors.
TODOs: