Fix drawing outside of expose calls #4949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Unless there's any objections I'll be merging this in the next few days |
skef
reviewed
Apr 28, 2022
Contributor
skef
left a comment
There was a problem hiding this comment.
I looked at these changes and although I don't think I've done a "real" review I get the basic idea and it looks OK to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the cases that I can find where drawing occurs outside of expose calls.
All modern toolkits force you to draw within expose events, and even now, only somewhat works with more than a few hacks in the GDK code.
Fixing this allows some of those hacks to be removed (and at times, removes the need for some triple-buffering)
Type of change