Fix resolution of program root #4956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging a45dad0 into dfb7830 - view on LGTM.com fixed alerts:
|
skef
approved these changes
Mar 21, 2022
Contributor
skef
left a comment
There was a problem hiding this comment.
I feel like you would lecture me about the added statics but I ain't got no problem with 'em. LGTM.
Contributor
Author
|
If you're referring to the statics in fsys.c, I'm pretty sure I reduced the net amount |
Contributor
|
@jtanx you might not have meant to leave the TRACE in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #4827, the app bundle's entrypoint is now a symlink to the real binary instead of a startup script, which throws off the resolution of the program root.
This fix checks to see if the determined root is valid, and if not, tries to resolve symlinks. Similar to #4626 but preserves existing behaviour if everything else is also symlinked properly.
Type of change
Fixes #4953