Fix lookup flags parsing #5338
Merged
Fix lookup flags parsing #5338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@skef, could you please take a look? |
skef
approved these changes
Jan 4, 2024
Contributor
skef
left a comment
There was a problem hiding this comment.
Yeah, seems like a typically Georgean artifact. Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parsing of lookup flags in an OT feature file import.
In a line like
lookupflag RightToLeft IgnoreMarks;the first flag is parsed in linefeaturefile.c:3192, and the next token is parsed on featurefile.c:3213. The problem is that after the second token is verified, there is another parsing command at featurefile.c:3222, which effectively discard the second token and picks yet another one.
Closes #5337