Support suplementary planes in SFD (emojis etc.) #5364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skef
approved these changes
Feb 4, 2024
Contributor
skef
left a comment
There was a problem hiding this comment.
I'm able to properly review maybe 70% of this, with the other 30% (the specifics of these transcodings down to the individual operations) left on trust.
Contributor
|
@JoesCat Happen to want to take a look at this before I merge? |
Contributor
Author
|
Regression testing (using bulk_test.sh, see #5365) passed with Each SFD file opened and saved anew with this PR and 20230101 respectively, all files are identical. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode strings are currently improperly converted when saved to SFD file. Specifically, conversion step to UTF-16 is skipped, effectively breaking all supplementary plane characters (like emojis or music notation).
This PR introduces proper conversion to/from UTF-16, TTF names like
"😀𝄞"are now correctly stored in SFD.Type of change
This fixes the issue of
SFDDumpUTF7Str{}/SFDReadUTF7Str()mentioned by @mf2vec-dev in #5354