Fix resource leak in unParseTTInstrs #5476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PySequence_GetItem adds a reference count to the argument it returns. Use PySequence_Fast() to simplify access.
skef
reviewed
Oct 6, 2024
Contributor
|
@iorsh any thoughts? |
Contributor
|
I'll review this and other stuff later today. |
Contributor
|
I'm not quite proficient in C-level Python reference counting. The change looks reasonable to me. |
iorsh
approved these changes
Oct 7, 2024
Contributor
|
I'm just going to override the checks rather than try to get the mac build working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PySequence_GetItem adds a reference count to the argument it returns. Use PySequence_Fast() to simplify access.
Type of change