-
Notifications
You must be signed in to change notification settings - Fork 764
Remove cv->back_img_out_of_date and cv->backimgs
#5625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iorsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
How does the GDK back-end handle the background images? |
Seems to just draw them unconditionally in Here's the diff of the original conditional, when the X11 backend was removed. GitHub's subpar UI doesn't seem to properly jump to it, but it's highlighted in orange in the middle of charview.c. |
From the code excerpt below (before #5612) it seems that all the backends do the same job in a different order: X11 (no Cairo):
Cairo:
I don't know what was the reason for the off-screen hack, maybe transparency or performance issues. |
|
This is fine to merge. I am still puzzling over it, though. Was the idea perhaps to be able to redraw the foreground continuously without redrawing the background? |
That sounds reasonable. Maybe this approach could have been implemented for GDK too, but with the modern hardware the delay is probably unnoticeable. |
As I mentioned in #5612 (comment),
cv->back_img_out_of_dateandcv->backimgswere only used by the X11 drawing backend, which has now been removed. We can therefore remove them as well now (as well as supporting functionality likeSC_OutOfDateBackground).Type of change