Skip to content

Commit b6c4691

Browse files
committed
feat(picker): reworked with native CSS Scroll Snap API
- the following parameters removed due to how native scroll works: `updateValuesOnMomentum`, `updateValuesOnTouchmove`, `updateValuesOnMousewheel`, `mousewheel` and `momentumRatio` - `.setValue` method doesn't accept `duration` anymore
1 parent aa74c25 commit b6c4691

File tree

5 files changed

+70
-298
lines changed

5 files changed

+70
-298
lines changed

src/core/components/picker/picker-class.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ class Picker extends Framework7Class {
152152
for (let i = 0; i < picker.cols.length; i += 1) {
153153
if (!picker.cols[i].divider) {
154154
picker.cols[i].calcSize();
155-
picker.cols[i].setValue(picker.cols[i].value, 0, false);
155+
picker.cols[i].setValue(picker.cols[i].value, false);
156156
}
157157
}
158158
}
@@ -188,7 +188,7 @@ class Picker extends Framework7Class {
188188
return value.join(' ');
189189
}
190190

191-
setValue(values, transition) {
191+
setValue(values) {
192192
const picker = this;
193193
let valueIndex = 0;
194194
if (picker.cols.length === 0) {
@@ -198,7 +198,7 @@ class Picker extends Framework7Class {
198198
}
199199
for (let i = 0; i < picker.cols.length; i += 1) {
200200
if (picker.cols[i] && !picker.cols[i].divider) {
201-
picker.cols[i].setValue(values[valueIndex], transition);
201+
picker.cols[i].setValue(values[valueIndex]);
202202
valueIndex += 1;
203203
}
204204
}
@@ -395,12 +395,12 @@ class Picker extends Framework7Class {
395395

396396
// Set value
397397
if (!initialized) {
398-
if (value) picker.setValue(value, 0);
398+
if (value) picker.setValue(value);
399399
else if (params.value) {
400-
picker.setValue(params.value, 0);
400+
picker.setValue(params.value);
401401
}
402402
} else if (value) {
403-
picker.setValue(value, 0);
403+
picker.setValue(value);
404404
}
405405

406406
// Extra focus

0 commit comments

Comments
 (0)