Sortable List nested ListInput's behavior
#3943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ListInput`'s with `sortable={false}` nested inside a sortable list were rendering the sortable handler.
This change allows `ListInput`'s sortable value to take precedence over a parent list whenever it's set, otherwise it behaves like usual.
Member
|
Merged, thanks, but instead of nullish coalescing I changed to ternary, as not sure babel is configured to understand it properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
ListInput's withsortable={false}were rendering the sortable handler when nested inside a sortable list.This change allows
ListInput's sortable value to take precedence over a parent list whenever it's set, otherwise it behaves like usual.