Description

In both the /ue/:unsubscribeId and /resubscribe/:unsubscribeId handlers in email-subscription.ts, origin was declared inside the try block. Since const is block-scoped, the catch block could not access it.

If an unexpected error occurred (for example, a Prisma connection failure), the catch block itself would throw:

ReferenceError: origin is not defined

This caused the request to return a 500 response instead of performing a graceful redirect with an error message.

Before

async (req, reply) => {
  try {
    const { origin } = getRedirectParams(req); // scoped to try block only
    // ...
  } catch (error) {
    return reply.redirectWithMessage(origin, { ... }); // ❌ ReferenceError
  }
}

After

async (req, reply) => {
  const { origin } = getRedirectParams(req); // accessible throughout handler

  try {
    // ...
  } catch (error) {
    return reply.redirectWithMessage(origin, { ... }); // ✅ works correctly
  }
}

Changes

• Moved getRedirectParams(req) outside the try block in the unsubscribe handler
• Moved getRedirectParams(req) outside the try block in the resubscribe handler

Affected File

• api/src/routes/public/email-subscription.ts

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitHub Codespaces.

Closes #67623