• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch emulate

Reviewing files that changed from the base of the PR and between 4a132a5 and 76dac75.

• mock/term_test.go
• vt/emulate.go
• vt/mode_test.go

vt/mode_test.go (1)

19-45: LGTM! Comprehensive test coverage for PmAutoMargin.

The test validates all string representations (Enable, Disable, Query, Reply) with proper escape sequences for DEC private mode 7 (automargin). The coverage includes all ModeStatus values, ensuring the formatting is correct.

vt/emulate.go (4)

68-68: LGTM! Increased input buffering capacity.

The readQ buffer size increase from 32 to 128 provides more headroom for queuing data from the emulator to the application, which should improve performance when handling bursts of input.

---

127-141: LGTM! Improved code documentation.

The inline comments clarify the control character handling (ESC, BEL, BS, NL, VT, FF, CR), making the code more readable without changing behavior.

---

425-428: LGTM! Bug fix to include '?' as a valid CSI prefix.

Changing the condition from b < '?' to b <= '?' correctly includes '?' (0x3F) as a CSI prefix character, which is essential for DEC private mode sequences like DECSET/DECRST (e.g., \x1b[?7h for automargin). The comprehensive tests in mock/term_test.go validate this works correctly.

---

430-434: LGTM! Bug fix for removing trailing intermediate bytes.

Replacing em.inBuf.ReadByte() with em.inBuf.Truncate(l - 1) correctly removes the trailing intermediate byte from the CSI parameter buffer. The previous code would have removed a byte from the front of the buffer instead of the end, which was incorrect.

mock/term_test.go (7)

63-108: LGTM! Comprehensive cursor movement test coverage.

The test thoroughly validates cursor movement commands (CUP, CUU, CUD, CUF, CUB, CNL, CPL) including boundary conditions where movements exceed window dimensions. The position checks after each operation ensure correct clamping behavior.

---

110-158: LGTM! Thorough DECALN test coverage.

The test validates the DEC Alignment Test (DECALN) sequence in three scenarios: basic fill, after clearing, and with attributes (bold). Each scenario correctly verifies that all cells contain the expected character ('E' or ' ') with the correct attributes.

---

160-177: LGTM! Simple and effective bell test.

The test validates that BEL characters (0x07) correctly increment the bell counter, verifying basic beeper functionality.

---

179-216: LGTM! Complete primary device attributes testing.

The test validates primary device attributes (DA) using both the modern CSI c and legacy ESC Z sequences. The response format checks correctly verify the VT level and attribute reporting.

---

218-244: LGTM! Extended attributes test validates terminal identification.

The test correctly verifies the extended terminal identification response to CSI > q, checking for proper DCS formatting and the expected terminal name/version string.

---

246-280: LGTM! Cursor position reporting test with proper coordinate translation.

The test validates cursor position reporting (DSR, CSI 6n) and correctly handles the translation between 0-based internal coordinates and 1-based reported coordinates. Testing both static position and position after movement ensures the feature works reliably.

---

282-307: LGTM! Comprehensive private mode testing.

The test thoroughly validates DECRQM (query), DECSET (enable), and DECRST (disable) for private modes, including:

• Automargin mode (7) state transitions (on→off→on)
• Invalid mode handling (1919 returns status 0=NA)
• Correct response format for all queries

The expected response string correctly matches the sequence of operations.