Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2e3028a58c1f1fbf08538443fc30a48ac4f6bacf
Choose a base ref
...
head repository: git/git
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 109bcb7d1d2f0d2f0514beec15779190c0b89575
Choose a head ref
  • 7 commits
  • 38 files changed
  • 2 contributors

Commits on Apr 1, 2026

  1. Merge branch 'ps/odb-generic-object-name-handling' into ps/odb-cleanup 

    * ps/odb-generic-object-name-handling:
  odb: introduce generic `odb_find_abbrev_len()`
  object-file: move logic to compute packed abbreviation length
  object-name: move logic to compute loose abbreviation length
  object-name: simplify computing common prefixes
  object-name: abbreviate loose object names without `disambiguate_state`
  object-name: merge `update_candidates()` and `match_prefix()`
  object-name: backend-generic `get_short_oid()`
  object-name: backend-generic `repo_collect_ambiguous()`
  object-name: extract function to parse object ID prefixes
  object-name: move logic to iterate through packed prefixed objects
  object-name: move logic to iterate through loose prefixed objects
  odb: introduce `struct odb_for_each_object_options`
  oidtree: extend iteration to allow for arbitrary return codes
  oidtree: modernize the code a bit
  object-file: fix sparse 'plain integer as NULL pointer' error
    @gitster
    gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    e104e63 View commit details
    Browse the repository at this point in the history

  2. CodingGuidelines: document our style for flags 

    We have recently iterated a bit on our style for flags. Document this.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    55903dc View commit details
    Browse the repository at this point in the history

  3. treewide: use enum for odb_for_each_object() flags 

    We've got a couple of callsites where we pass `odb_for_each_object()`
flags, but accept an `unsigned` flags field instead of the corresponding
enum. Adapt these to accept the enum type instead.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    75c7026 View commit details
    Browse the repository at this point in the history

  4. odb: rename odb_write_object() flags 

    Rename `odb_write_object()` flags to be properly prefixed with the
function name.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    ff2e9d8 View commit details
    Browse the repository at this point in the history

  5. odb: use enum for odb_write_object flags 

    We've got a couple of functions that accept `odb_write_object()` flags,
but all of them accept the flags as an `unsigned` integer. In fact, we
don't even have an `enum` for the flags field.

Introduce this `enum` and adapt functions accordingly according to our
coding style.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    b2d421e View commit details
    Browse the repository at this point in the history

  6. odb: rename odb_has_object() flags 

    Rename `odb_has_object()` flags to be properly prefixed with the
function name.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    c63911b View commit details
    Browse the repository at this point in the history

  7. odb: drop unneeded headers and forward decls 

    There's a couple of unneeded forward declarations and headers in
"odb.h". Drop these.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    109bcb7 View commit details
    Browse the repository at this point in the history
Loading