Fix overlapping batches in refspec splitting

navntoft · navntoft · commit 291c4c61d990 · 2025-09-16T08:38:39.000+02:00
The splitLargeRefSpecs function had a logic error where it incremented
by 25 but used a batch size of 100, creating overlapping batches that
pushed the same refs multiple times.
diff --git a/internal/push/push.go b/internal/push/push.go
@@ -164,9 +164,10 @@ func (pushService *pushService) createRepository() (*github.Repository, error) {
 }
 
 func splitLargeRefSpecs(refSpecs []config.RefSpec) [][]config.RefSpec {
+	batchSize := 25
 	splitRefSpecs := [][]config.RefSpec{}
-	for i := 0; i < len(refSpecs); i += 25 {
-		end := i + 100
+	for i := 0; i < len(refSpecs); i += batchSize {
+		end := i + batchSize
 		if end > len(refSpecs) {
 			end = len(refSpecs)
 		}

Original file line number	Diff line number	Diff line change
`@@ -164,9 +164,10 @@ func (pushService pushService) createRepository() (github.Repository, error) {`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`func splitLargeRefSpecs(refSpecs []config.RefSpec) [][]config.RefSpec {`
	`167`	`+ batchSize := 25`
`167`	`168`	`splitRefSpecs := [][]config.RefSpec{}`
`168`		`- for i := 0; i < len(refSpecs); i += 25 {`
`169`		`- end := i + 100`
	`169`	`+ for i := 0; i < len(refSpecs); i += batchSize {`
	`170`	`+ end := i + batchSize`
`170`	`171`	`if end > len(refSpecs) {`
`171`	`172`	`end = len(refSpecs)`
`172`	`173`	`}`