Clarify that GsonBuilder.setExclusionStrategies does not replace existing ones#2168
Merged
eamonnmcmanus merged 2 commits intogoogle:masterfrom Aug 6, 2022
Conversation
Member
|
That's annoying. Obviously the method should have been called |
eamonnmcmanus
requested changes
Aug 4, 2022
306a015 to
6c7d274
Compare
eamonnmcmanus
approved these changes
Aug 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally
set...methods on builders make it sound like the previously specified value is overwritten, especially when there also existadd...methods. However, this is not the case here so the documentation should explicitly mention this.Feedback regarding the wording is appreciated.