Verify that JsonTreeReader and JsonTreeWriter override all methods#2181
Merged
eamonnmcmanus merged 3 commits intogoogle:masterfrom Aug 23, 2022
Conversation
If those classes do not override one of the JsonReader or JsonWriter methods the user might encounter an AssertionError.
eamonnmcmanus
requested changes
Aug 22, 2022
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Very helpful, thanks! Just one small suggestion to simplify slightly.
…/JsonTreeReader-JsonTreeWriter-overrides-test
eamonnmcmanus
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If those classes do not override one of the
JsonReaderorJsonWritermethods the user might encounter anAssertionError.This was originally suggested in #2132 (comment).
Related issues: