Conversation
Fixes #2260 Copied the implementation with the jakarta.servlet namespace using the same methology as googleapis/google-oauth-java-client#1115. - Replaced javax with jakarta and declared the dependency with provided scope. - Keeping the classes as `Beta` annotated. - No tests exist for the classes. - Added `@since 2.6.0` as the last release was 2.5.1.
diegomarquezp
approved these changes
May 24, 2024
Contributor
diegomarquezp
left a comment
There was a problem hiding this comment.
TLDR - Jakarta webservers don't contain javax classes, producing NoClassFoundError if the user code references any of the webhooks (example). This PR adds copies of the webhooks using a special package suffix jakarta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2260
Internal bug b/342581012.
I copied the WebhookUtils and WebhookUtils (https://github.com/googleapis/google-api-java-client/tree/2d25655b94dc1ae93b5c3a97046daf6a35a9923b/google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/notifications ) replacing the javax namespace with the jakarta.servlet namespace.
This is the same methology as googleapis/google-oauth-java-client#1115.
provided scope.
Betaannotated.@since 2.6.0as the last release was 2.5.1.