Merged
Conversation
|
zhumin8
approved these changes
Jan 16, 2025
Contributor
zhumin8
left a comment
There was a problem hiding this comment.
Thanks Diego for fixing this!
super nit: Could you update the link to "docs on bootstrapping config" in the description? It's pointing to sdk-platform-java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1545 ☕
Config structure borrowed from https://github.com/googleapis/sdk-platform-java + docs on bootstrapping config
Proof generated PR (updates readmes mentioned in parent issue). PR manually generated via
release-please release-pr --token 🚀 --repo-url=https://github.com/googleapis/google-auth-library-java --target-branch setup-release-pleaseProof that the config is valid (same command in parent issue used to fail):
Follow ups