feat(storage): allow non default service account #11137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritone
approved these changes
Nov 15, 2024
Contributor
tritone
left a comment
There was a problem hiding this comment.
We should also likely disable this test for cloudtop as well though since it seems to fail there...
Contributor
Author
|
Cloudtop works you just need to set environment variable: Direct Connectivity is disabled by default on cloudtop. |
This was referenced Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Go Storage enables DirectPath by default, the client needs to enable the flag to allow non-default service accounts as well.
In talking with @mohanli-ml, there's an approval process that GCS has already done as a service and we only need to enable it client side. Mohan can i get your approval on this PR to ack this context?
Fixes: #11128
Triggered a continuous job with this PR: