Skip to content

fix(bigtable): Mutate groups even after first error #11434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhshkh merged 11 commits into from
Jan 15, 2025
Merged

fix(bigtable): Mutate groups even after first error #11434

bhshkh merged 11 commits into from
Jan 15, 2025

Conversation

@bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 10, 2025 •
edited
Loading

This PR has 2 changes

  1. If the number of mutations is greater than maxMutations, the library breaks down the mutations into smaller groups. If any of the group fails, no further groups are tried and the first error seen is returned. In this PR, this behaviour has been changed by trying to apply all further groups even if one of the group fails.
  2. If the MutateRowsRequest fails without returning any response (e.g. in case of DeadlineExceeded error), the per mutation errors are nil. In this PR, this behaviour has been changed to set per mutation error.

@bhshkh bhshkh requested review from a team as code owners January 10, 2025 19:32
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 10, 2025
@bhshkh bhshkh requested a review from gkevinzheng January 10, 2025 19:33
@bhshkh bhshkh enabled auto-merge (squash) January 10, 2025 22:12
@bhshkh bhshkh disabled auto-merge January 14, 2025 23:25
@bhshkh bhshkh marked this pull request as draft January 14, 2025 23:25
@bhshkh bhshkh marked this pull request as ready for review January 15, 2025 04:57
@bhshkh bhshkh requested a review from andre-sampaio January 15, 2025 04:59
@bhshkh bhshkh enabled auto-merge (squash) January 15, 2025 19:17
@bhshkh bhshkh disabled auto-merge January 15, 2025 19:21
@bhshkh bhshkh enabled auto-merge (squash) January 15, 2025 21:59
@bhshkh bhshkh merged commit 6ffe32b into googleapis:main Jan 15, 2025
8 of 10 checks passed
@release-please release-please bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

+1 more reviewer

@andre-sampaio andre-sampaio andre-sampaio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhshkh @andre-sampaio @gkevinzheng