feat(storage): wrap NotFound errors for buckets and objects #11519
+63
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code that checks directly against ErrBucketNotExist and ErrObjectNotExist will break; use `errors.Is()` instead.
tritone
approved these changes
Jan 29, 2025
Contributor
tritone
left a comment
There was a problem hiding this comment.
Looks good, nice changes!
Maybe add to the docs for the sentinel errors that they should be checked using errors.Is?
This was referenced Mar 12, 2025
klakin-pivotal
added a commit
to cloudfoundry/bosh-gcscli
that referenced
this pull request
Mar 17, 2025
Version 1.51.0 of the 'cloud.google.com/go/storage' library wraps NotFound errors for buckets and objects. As described in the PR introducing the change, this breaks client code that doesn't use 'errors.Is()' to check the error type. This commit updates the client code to work the way the library now expects it to. The PR that introduces the breaking change in question is here: <googleapis/google-cloud-go#11519>
a-nogikh
added a commit
to a-nogikh/syzkaller
that referenced
this pull request
May 2, 2025
After googleapis/google-cloud-go#11519, the cloud storage library wraps the errors which we used to check directly. This has led to multiple asset upload errors.
github-merge-queue bot
pushed a commit
to google/syzkaller
that referenced
this pull request
May 2, 2025
After googleapis/google-cloud-go#11519, the cloud storage library wraps the errors which we used to check directly. This has led to multiple asset upload errors.
1 task
9 tasks
steved
added a commit
to steved/vault
that referenced
this pull request
Jul 17, 2025
After googleapis/google-cloud-go#11519, errors must be checked with `errors.Is`. Addresses hashicorp#31125.
vanja-p
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Jul 25, 2025
) Reverts #9938 This upgrades the GCS dependency again, but this time fixing the error handling that was broken by googleapis/google-cloud-go#11519. I confirmed that the new error handling works for both HTTP and gRPC.
mpalmi
added a commit
to hashicorp/vault
that referenced
this pull request
Jul 31, 2025
…31274) After googleapis/google-cloud-go#11519, errors must be checked with `errors.Is`. Addresses #31125. Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
sapk
pushed a commit
to sapk-fork/vault
that referenced
this pull request
Oct 6, 2025
…ashicorp#31274) After googleapis/google-cloud-go#11519, errors must be checked with `errors.Is`. Addresses hashicorp#31125. Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code that checks directly against ErrBucketNotExist and ErrObjectNotExist will break; use
errors.Is()instead.This change allows users to inspect the underlying error.
Fixes #2587