feat(bigtable): Use delay from RetryInfo #11955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
just a few drive by comments
6704f90 to
74cc8ad
Compare
429b8ff to
7508529
Compare
7508529 to
2a9343f
Compare
gkevinzheng
reviewed
May 5, 2025
bigtable/bigtable.go
Outdated
Comment on lines
208
to
209
| defaultRetryOption = newRetryOption(clientOnlyRetry, false /* disableRetryInfo */) | ||
| defaultExecuteQueryRetryOption = newRetryOption(clientOnlyExecuteQueryRetry, false /* disableRetryInfo */) |
Contributor
There was a problem hiding this comment.
It looks like disableRetryInfo is false here. Does this mean these two comments are incorrect?
Contributor
Author
There was a problem hiding this comment.
The comment is just to denote the argument name in function. I was trying to do something similar to https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.md?cl=head#Function_Argument_Comments
removed now
gkevinzheng
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/368356092
https://github.com/grpc/proposal/blob/90462b53883a0455157f9a0fd0a76b36fa567acc/A6-client-retries.md?plain=1#L209