fix(storage): pass all user options to NewService #12615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows user-supplied option.WithLogger to be honored. Fixes googleapis#12475
BrennaEpp
approved these changes
Jul 30, 2025
k4leung4
added a commit
to chainguard-dev/terraform-infra-common
that referenced
this pull request
Aug 22, 2025
fix ``` storage client: WithHTTPClient is incompatible with gRPC dial options ``` our client options are grpc dial options, which isnt compatible with storage, which uses WithHTTPClient. this worked previously as the options wasnt passed through to the service, but with 1.56.1 in particular, this fix, googleapis/google-cloud-go#12615 Signed-off-by: Kenny Leung <kleung@chainguard.dev>
imjasonh
pushed a commit
to imjasonh/terraform-cloudrun-glue
that referenced
this pull request
Nov 21, 2025
fix ``` storage client: WithHTTPClient is incompatible with gRPC dial options ``` our client options are grpc dial options, which isnt compatible with storage, which uses WithHTTPClient. this worked previously as the options wasnt passed through to the service, but with 1.56.1 in particular, this fix, googleapis/google-cloud-go#12615 Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows user-supplied option.WithLogger to be honored.
Fixes #12475