Skip to content

ci: Airlock-friendly build dependencies#1135

Merged
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:troubleshooting_maven
Jan 9, 2025
Merged

ci: Airlock-friendly build dependencies#1135
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:troubleshooting_maven

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Jan 9, 2025

Airlock needs newer version of the Maven plugins. We also do not need to declare nexus-staging-maven-plugin by default.

@suztomo suztomo requested a review from a team January 9, 2025 00:31
@suztomo suztomo requested a review from a team as a code owner January 9, 2025 00:31
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 9, 2025
@suztomo suztomo force-pushed the troubleshooting_maven branch from 88e00f2 to 52624a5 Compare January 9, 2025 00:32
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use shared config as parent?

@suztomo suztomo merged commit b676657 into googleapis:main Jan 9, 2025
14 checks passed
@suztomo
Copy link
Member Author

suztomo commented Jan 9, 2025

I tried that idea and in theory it should work but it became messy (#1133 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants