Skip to content

Commit 0e42ad0

Browse files
Google APIscopybara-github
authored andcommitted
feat: Clarify Batch API proto doc about pubsub notifications
--- feat: add Batch Managed Container support for v1alpha PiperOrigin-RevId: 554622486
1 parent 48861b3 commit 0e42ad0

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

google/cloud/batch/v1/job.proto

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,12 @@ message JobStatus {
184184
// Notification configurations.
185185
message JobNotification {
186186
// Message details.
187-
// Describe the attribute that a message should have.
188-
// Without specified message attributes, no message will be sent by default.
187+
// Describe the conditions under which messages will be sent.
188+
// If no attribute is defined, no message will be sent by default.
189+
// One message should specify either the job or the task level attributes,
190+
// but not both. For example,
191+
// job level: JOB_STATE_CHANGED and/or a specified new_job_state;
192+
// task level: TASK_STATE_CHANGED and/or a specified new_task_state.
189193
message Message {
190194
// The message type.
191195
Type type = 1;
@@ -210,8 +214,8 @@ message JobNotification {
210214
}
211215

212216
// The Pub/Sub topic where notifications like the job state changes
213-
// will be published. This topic exist in the same project as the job
214-
// and billings will be charged to this project.
217+
// will be published. The topic must exist in the same project as
218+
// the job and billings will be charged to this project.
215219
// If not specified, no Pub/Sub messages will be sent.
216220
// Topic format: `projects/{project}/topics/{topic}`.
217221
string pubsub_topic = 1;

google/cloud/batch/v1/task.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ syntax = "proto3";
1616

1717
package google.cloud.batch.v1;
1818

19+
import "google/api/field_behavior.proto";
1920
import "google/api/resource.proto";
2021
import "google/cloud/batch/v1/volume.proto";
2122
import "google/protobuf/duration.proto";

0 commit comments

Comments
 (0)