chore: add plumbing to allow customer to enable reporting OT metrics#2581
Merged
agrawal-siddharth merged 1 commit intogoogleapis:mainfrom Jul 26, 2024
Merged
Conversation
yirutang
reviewed
Jul 26, 2024
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Is this flag actually used?
Contributor
Author
|
No, as yet the flag is not used. Next checkin will factor out the metrics reporting logic and will begin using it. |
yirutang
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prepares for a future change that will actually consume the flag to enable/disable reporting of OpenTelemetry metrics.