This repository was archived by the owner on May 8, 2026. It is now read-only.
feat: update tracers to use built in metrics#1244
Merged
Merged
Conversation
25d61e5 to
ca28be6
Compare
db124f2 to
8a2aa0e
Compare
38b2804 to
353aeb7
Compare
igorbernstein2
suggested changes
Jun 8, 2022
a198247 to
82e63f0
Compare
igorbernstein2
suggested changes
Jun 21, 2022
igorbernstein2
suggested changes
Jun 28, 2022
| statsRecorderWrapper)); | ||
|
|
||
| final long applicationLatency = 200; | ||
| final AtomicInteger counter = new AtomicInteger(0); |
Contributor
There was a problem hiding this comment.
why is this atomic?
Contributor
Author
There was a problem hiding this comment.
Hmm, because it's used in response observer so it needs to be final, and I also need to update the value, so i need to AtomicInteger here?
Comment on lines
+317
to
+320
| assertThat(zone.getAllValues()).containsExactly(UNDEFINED, UNDEFINED, UNDEFINED, UNDEFINED); | ||
| assertThat(cluster.getAllValues()).containsExactly(UNDEFINED, UNDEFINED, UNDEFINED, UNDEFINED); | ||
| assertThat(status.getAllValues()).containsExactly("UNAVAILABLE", "UNAVAILABLE", "OK", "OK"); | ||
| } |
Contributor
There was a problem hiding this comment.
Should there be a test that checks what happens when a retry attempt changes cluster/zone?
Contributor
Author
There was a problem hiding this comment.
It will be! In my next pr :)
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.0...v2.9.0) (2022-06-30) ### Features * add built-in metric constants ([#1243](#1243)) ([b1fc00a](b1fc00a)) * **generated:** Add storage_utilization_gib_per_node to Autoscaling target ([a4c6621](a4c6621)) * **generated:** Cloud Bigtable Undelete Table service and message proto files ([a4c6621](a4c6621)) * update tracers to use built in metrics ([#1244](#1244)) ([df77560](df77560)) ### Bug Fixes * fix flaky test ([#1293](#1293)) ([146c824](146c824)) * remove the shaded profile from root pom ([#1274](#1274)) ([5eafcc3](5eafcc3)) * rename HeaderTracer callables to BigtableTracer callables ([#1276](#1276)) ([e0bd6c9](e0bd6c9)) * rename response observer and callbacks ([#1291](#1291)) ([2705a47](2705a47)) ### Documentation * **sample:** update README for native image sample ([#1281](#1281)) ([4a3a2c9](4a3a2c9)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#1285](#1285)) ([1dc7787](1dc7787)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#1283](#1283)) ([ba7844a](ba7844a)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1284](#1284)) ([75d0066](75d0066)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mpeddada1
pushed a commit
that referenced
this pull request
Jul 18, 2022
* feat: add built in metrics measure and views * remove status from application latency * Rename methods and add comments * update based on comments * feat: update tracers to use built in metrics * update on comments * make stopwatch thread safe * update comments * calculate application latency correctly * remove unused check * clean up tests * fix typo * update test * fix flaky test * fix retry count
mpeddada1
pushed a commit
that referenced
this pull request
Jul 18, 2022
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.0...v2.9.0) (2022-06-30) ### Features * add built-in metric constants ([#1243](#1243)) ([b1fc00a](b1fc00a)) * **generated:** Add storage_utilization_gib_per_node to Autoscaling target ([a4c6621](a4c6621)) * **generated:** Cloud Bigtable Undelete Table service and message proto files ([a4c6621](a4c6621)) * update tracers to use built in metrics ([#1244](#1244)) ([df77560](df77560)) ### Bug Fixes * fix flaky test ([#1293](#1293)) ([146c824](146c824)) * remove the shaded profile from root pom ([#1274](#1274)) ([5eafcc3](5eafcc3)) * rename HeaderTracer callables to BigtableTracer callables ([#1276](#1276)) ([e0bd6c9](e0bd6c9)) * rename response observer and callbacks ([#1291](#1291)) ([2705a47](2705a47)) ### Documentation * **sample:** update README for native image sample ([#1281](#1281)) ([4a3a2c9](4a3a2c9)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#1285](#1285)) ([1dc7787](1dc7787)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#1283](#1283)) ([ba7844a](ba7844a)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1284](#1284)) ([75d0066](75d0066)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.