fix: rate limiting should be ineffective when RateLimitInfo is not present#2243
Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom May 30, 2024
Conversation
4f0fa05 to
08881af
Compare
igorbernstein2
requested changes
May 29, 2024
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Show resolved
Hide resolved
b919180 to
e02261f
Compare
Contributor
Author
|
@igorbernstein2 what kind of rollback plan we could implement for such changes? |
igorbernstein2
requested changes
May 30, 2024
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
94fd611 to
da5fb62
Compare
Built a new ConditionalRateLimiter that can be disabled but keep the rate. Also moved setRate() into the ConditionalRateLimiter. Update and disable is throttled based on period from RateLimitInfo. By default the rate limiter is disabled when initiated. Enable, disable and update rate will be logged as INFO, as they're critical to the run of the worker and only logged per 10s by default for each worker thread.
da5fb62 to
b219948
Compare
igorbernstein2
approved these changes
May 30, 2024
Contributor
|
re rollback - this is the rollback mechanism for the throttling feature. I dont think we need a rollback mechanism for the the rollback mechanism :) |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Built a new ConditionalRateLimiter that can be disabled but keep the rate. Also moved setRate() into the ConditionalRateLimiter. Update and disable is throttled based on period from RateLimitInfo. By default the rate limiter is disabled when initiated. Enable, disable and update rate will be logged as INFO, as they're critical to the run of the worker and only logged per 10s by default for each worker thread.
b219948 to
ce64f7e
Compare
…thub.com/kongweihan/java-bigtable into fix-flow-control-rate-limit-info-missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.