feat: Add additional Firestore query snippets#1790
Merged
iennae merged 10 commits intogoogleapis:mainfrom Aug 29, 2024
kevkim-codes:firestore-samples
Merged
feat: Add additional Firestore query snippets#1790iennae merged 10 commits intogoogleapis:mainfrom kevkim-codes:firestore-samples
iennae merged 10 commits intogoogleapis:mainfrom
kevkim-codes:firestore-samples
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
It looks like Kokoro sample tests failed with: Not super familiar with firestore, do we need to create an index? https://cloud.google.com/firestore/docs/query-data/indexing |
cindy-peng
reviewed
Aug 15, 2024
...ets/src/main/java/com/example/firestore/snippets/MultipleRangeInequalityFiltersSnippets.java
Outdated
Show resolved
Hide resolved
...s/src/test/java/com/example/firestore/snippets/MultipleRangeInequalityFiltersSnippetsIT.java
Outdated
Show resolved
Hide resolved
...ets/src/main/java/com/example/firestore/snippets/MultipleRangeInequalityFiltersSnippets.java
Show resolved
Hide resolved
Contributor
Author
Created new indexes for the sample build! Kokoro build passes now. |
cindy-peng
approved these changes
Aug 16, 2024
jiayou97
approved these changes
Aug 21, 2024
jiayou97
left a comment
There was a problem hiding this comment.
Hi, this is Jia from Firestore. Thanks for making the change!
iennae
approved these changes
Aug 29, 2024
|
Hi @kevkim-codes , still missing the Datastore version with region tag: datastore_query_filter_compound_multi_ineq |
This was referenced Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a region tag to use for documentation: Docsite page: https://firebase.google.com/docs/firestore/query-data/multiple-range-fields