Skip to content

chore: CODEOWNERS for generated Java code#1938

Merged
tom-andersen merged 2 commits intomainfrom
suztomo-patch-1
Nov 25, 2024
Merged

chore: CODEOWNERS for generated Java code#1938
tom-andersen merged 2 commits intomainfrom
suztomo-patch-1

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Nov 22, 2024 •
edited
Loading

This pattern for generated Java code allows us (Cloud Java / yoshi-java) to merge the pull requests without additional reviews.

b/379670583

suztomo@suztomo2:~/java-firestore$ git log --author=cloud-java-bot --name-status -100 -- google-cloud-firestore* |grep ".java$"
M	google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/FirestoreAdminSettings.java
M	google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreAdminStubSettings.java
M	google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreStubSettings.java
M	google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/FirestoreAdminClient.java
M	google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/FirestoreAdminSettings.java
M	google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreAdminStubSettings.java
M	google-cloud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/FirestoreAdminClientHttpJsonTest.java
M	google-cloud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/FirestoreAdminClientTest.java
M	google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/FirestoreSettings.java
M	google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreStubSettings.java
M	google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreAdminStubSettings.java
M	google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreStubSettings.java

The "*Client.java" and "*Settings.java" are good patterns to capture them.

suztomo@suztomo2:~/java-firestore$ find google-cloud-firestore google-cloud-firestore-admin -name '*Client.java'
google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/FirestoreClient.java
google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/FirestoreAdminClient.java
suztomo@suztomo2:~/java-firestore$ find google-cloud-firestore google-cloud-firestore-admin -name '*Settings.java'
google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/FirestoreSettings.java
google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreStubSettings.java
google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreAdminStubSettings.java
google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/FirestoreAdminSettings.java

@suztomo
chore: CODEOWNERS for generated Java code
738c303 
This patterns for generated Java code allows us (Cloud Java / yoshi-java) to merge the pull requests without additional reviews.

b/379670583
@suztomo suztomo requested a review from a team November 22, 2024 19:12
@suztomo suztomo requested a review from a team as a code owner November 22, 2024 19:12
@generated-files-bot
Copy link

generated-files-bot bot commented Nov 22, 2024

Warning: This pull request is touching the following templated files:

  • .github/CODEOWNERS

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Nov 22, 2024
@suztomo
Copy link
Member Author

suztomo commented Nov 22, 2024

@ehsannas @tom-andersen With this change, you don't have to review the code generation pull requests like this #1923. What do you think?

ehsannas
ehsannas approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds like a good thing! That'll help @tom-andersen

@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2024
@tom-andersen tom-andersen merged commit 945e8e8 into main Nov 25, 2024
@tom-andersen tom-andersen deleted the suztomo-patch-1 branch November 25, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas ehsannas approved these changes

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @ehsannas @tom-andersen @yoshi-kokoro