chore: move tests which use FakeServer to be Integration Tests#1987
Merged
BenWhitehead merged 1 commit intomainfrom Apr 18, 2023
Merged
chore: move tests which use FakeServer to be Integration Tests#1987BenWhitehead merged 1 commit intomainfrom
BenWhitehead merged 1 commit intomainfrom
Conversation
GitHub actions seem to sometimes have issues with tcp connection's lingering longer than they should, or having things delayed. Other languages have encountered TCP issues in their actions too. In an effort to try and reduce the likelihood of this causing build flakiness move these test which use FakeServer to be Integration tests where we haven't encountered these kinds of failures.
sydney-munro
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub actions seem to sometimes have issues with tcp connection's lingering longer than they should, or having things delayed. Other languages have encountered TCP issues in their actions too.
In an effort to try and reduce the likelihood of this causing build flakiness move these test which use FakeServer to be Integration tests where we haven't encountered these kinds of failures.
Fixes #1748