test: add integration test to verify behavior of reader with effective length <= 0#1988
Merged
BenWhitehead merged 1 commit intomainfrom Apr 25, 2023
Merged
test: add integration test to verify behavior of reader with effective length <= 0#1988BenWhitehead merged 1 commit intomainfrom
BenWhitehead merged 1 commit intomainfrom
Conversation
…gth <= 0 StorageReadChannel is able to detect when an effective read length is <= 0 and will return EOF without sending an RPC. If we ever return object metadata along with a read, we will need to amend this behavior so that the metadata can be resolved.
sydney-munro
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageReadChannel is able to detect when an effective read length is <= 0 and will return EOF without sending an RPC.
If we ever return object metadata along with a read, we will need to amend this behavior so that the metadata can be resolved.