samples: Add StorageControl Quickstart Sample#2479
Merged
sydney-munro merged 9 commits intomainfrom Apr 3, 2024
Merged
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
Warning: This pull request is touching the following templated files:
|
0fd293b to
950e13d
Compare
0197e9a to
d39feb2
Compare
d39feb2 to
9b206f5
Compare
frankyn
reviewed
Apr 1, 2024
samples/snippets/src/main/java/com/example/storage/QuickstartStorageControlSample.java
Outdated
Show resolved
Hide resolved
| public static void main(String... args) throws Exception { | ||
| String bucketName = args[0]; // "your-bucket-name"; | ||
| StorageControlClient storageControlClient = StorageControlClient.create(); | ||
| GetStorageLayoutRequest request = GetStorageLayoutRequest.newBuilder() |
Contributor
There was a problem hiding this comment.
May help to clarify that _ represents global bucket namespace;
6cfb588 to
aff6140
Compare
frankyn
approved these changes
Apr 2, 2024
frankyn
reviewed
Apr 3, 2024
| @@ -28,9 +28,6 @@ | |||
| public class QuickstartStorageControlSample { | |||
| public static void main(String... args) throws Exception { | |||
| String bucketName = args[0]; // "your-bucket-name"; | |||
Contributor
There was a problem hiding this comment.
Linter will probably chime in but remove the imports for storage client as well
88b5691 to
20d795f
Compare
frankyn
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2477