Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

Commit 9ff9521

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix!: rename the type FunnelFilter to FunnelFieldFilter (#218)
fix!: rename the `funnel_filter` field of the `FunnelFilterExpression` type to `funnel_field_filter` PiperOrigin-RevId: 455204231 Source-Link: googleapis/googleapis@4849480 Source-Link: https://github.com/googleapis/googleapis-gen/commit/589642d0a68a2c519273cf0f7d7947b19cd99eac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTg5NjQyZDBhNjhhMmM1MTkyNzNjZjBmN2Q3OTQ3YjE5Y2Q5OWVhYyJ9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 7a5b80e commit 9ff9521

8 files changed

Lines changed: 162 additions & 151 deletions

File tree

‎protos/google/analytics/data/v1alpha/analytics_data_api.proto‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,12 @@ message RunFunnelReportRequest {
9696

9797
// If specified, next action adds a dimension to the funnel visualization sub
9898
// report response. This next action dimension expands each funnel step to the
99-
// unique values of the next action. For example a breakdown by the
99+
// unique values of the next action. For example a next action of the
100100
// `eventName` dimension will create rows for several events (i.e.
101101
// `session_start` & `click`) and the total.
102+
//
103+
// Next action only supports `eventName` and most Page / Screen dimensions
104+
// like `pageTitle` and `pagePath`.
102105
FunnelNextAction funnel_next_action = 5;
103106

104107
// The funnel visualization type controls the dimensions present in the funnel

‎protos/google/analytics/data/v1alpha/data.proto‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,10 @@ message FunnelNextAction {
403403
// The dimension column added to the funnel visualization sub report response.
404404
// The next action dimension returns the next dimension value of this
405405
// dimension after the user has attained the `i`th funnel step.
406-
// `nextActionDimension` currently only supports the `eventName` dimension.
406+
//
407+
// `nextActionDimension` currently only supports `eventName` and most Page /
408+
// Screen dimensions like `pageTitle` and `pagePath`. `nextActionDimension`
409+
// cannot be a dimension expression.
407410
Dimension next_action_dimension = 1;
408411

409412
// The maximum number of distinct values of the breakdown dimension to return
@@ -1026,8 +1029,8 @@ message FunnelFilterExpression {
10261029
// The FunnelFilterExpression is NOT of `notExpression`.
10271030
FunnelFilterExpression not_expression = 3;
10281031

1029-
// A primitive funnel filter.
1030-
FunnelFilter funnel_filter = 4;
1032+
// A funnel filter for a dimension or metric.
1033+
FunnelFieldFilter funnel_field_filter = 4;
10311034

10321035
// Creates a filter that matches events of a single event name. If a
10331036
// parameter filter expression is specified, only the subset of events that
@@ -1044,7 +1047,7 @@ message FunnelFilterExpressionList {
10441047
}
10451048

10461049
// An expression to filter dimension or metric values.
1047-
message FunnelFilter {
1050+
message FunnelFieldFilter {
10481051
// The dimension name or metric name.
10491052
string field_name = 1;
10501053

‎protos/protos.d.ts‎

Lines changed: 45 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)