fix: better support for fallback mode (#170)

gcf-owl-bot[bot] · web-flow · commit fa2e0b5991a8 · 2022-08-23T00:06:16.000Z
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: https://github.com/googleapis/googleapis-gen/commit/cb6f37aeff2a3472e40a7bbace8c67d75e24bee5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
diff --git a/samples/generated/v1/binauthz_management_service_v1.create_attestor.js b/samples/generated/v1/binauthz_management_service_v1.create_attestor.js
@@ -23,6 +23,9 @@
 function main(parent, attestorId, attestor) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_CreateAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/binauthz_management_service_v1.delete_attestor.js b/samples/generated/v1/binauthz_management_service_v1.delete_attestor.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_DeleteAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/binauthz_management_service_v1.get_attestor.js b/samples/generated/v1/binauthz_management_service_v1.get_attestor.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_GetAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/binauthz_management_service_v1.get_policy.js b/samples/generated/v1/binauthz_management_service_v1.get_policy.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_GetPolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/binauthz_management_service_v1.list_attestors.js b/samples/generated/v1/binauthz_management_service_v1.list_attestors.js
@@ -23,6 +23,9 @@
 function main(parent) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_ListAttestors_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/binauthz_management_service_v1.update_attestor.js b/samples/generated/v1/binauthz_management_service_v1.update_attestor.js
@@ -23,6 +23,9 @@
 function main(attestor) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_UpdateAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/binauthz_management_service_v1.update_policy.js b/samples/generated/v1/binauthz_management_service_v1.update_policy.js
@@ -23,6 +23,9 @@
 function main(policy) {
   // [START binaryauthorization_v1_generated_BinauthzManagementServiceV1_UpdatePolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/snippet_metadata.google.cloud.binaryauthorization.v1.json b/samples/generated/v1/snippet_metadata.google.cloud.binaryauthorization.v1.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -62,7 +62,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -102,7 +102,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 62,
+                    "end": 65,
                     "type": "FULL"
                 }
             ],
@@ -150,7 +150,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -190,7 +190,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -230,7 +230,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 64,
+                    "end": 67,
                     "type": "FULL"
                 }
             ],
@@ -278,7 +278,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -318,7 +318,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -358,7 +358,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 72,
+                    "end": 75,
                     "type": "FULL"
                 }
             ],
diff --git a/samples/generated/v1/system_policy_v1.get_system_policy.js b/samples/generated/v1/system_policy_v1.get_system_policy.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1_generated_SystemPolicyV1_GetSystemPolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1/validation_helper_v1.validate_attestation_occurrence.js b/samples/generated/v1/validation_helper_v1.validate_attestation_occurrence.js
@@ -23,6 +23,9 @@
 function main(attestor, attestation, occurrenceNote, occurrenceResourceUri) {
   // [START binaryauthorization_v1_generated_ValidationHelperV1_ValidateAttestationOccurrence_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.create_attestor.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.create_attestor.js
@@ -23,6 +23,9 @@
 function main(parent, attestorId, attestor) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_CreateAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.delete_attestor.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.delete_attestor.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_DeleteAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.get_attestor.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.get_attestor.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_GetAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.get_policy.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.get_policy.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_GetPolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.list_attestors.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.list_attestors.js
@@ -23,6 +23,9 @@
 function main(parent) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_ListAttestors_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.update_attestor.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.update_attestor.js
@@ -23,6 +23,9 @@
 function main(attestor) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_UpdateAttestor_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/binauthz_management_service_v1_beta1.update_policy.js b/samples/generated/v1beta1/binauthz_management_service_v1_beta1.update_policy.js
@@ -23,6 +23,9 @@
 function main(policy) {
   // [START binaryauthorization_v1beta1_generated_BinauthzManagementServiceV1Beta1_UpdatePolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/samples/generated/v1beta1/snippet_metadata.google.cloud.binaryauthorization.v1beta1.json b/samples/generated/v1beta1/snippet_metadata.google.cloud.binaryauthorization.v1beta1.json
@@ -22,7 +22,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -62,7 +62,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -102,7 +102,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 62,
+                    "end": 65,
                     "type": "FULL"
                 }
             ],
@@ -150,7 +150,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -190,7 +190,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 52,
+                    "end": 55,
                     "type": "FULL"
                 }
             ],
@@ -230,7 +230,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 64,
+                    "end": 67,
                     "type": "FULL"
                 }
             ],
@@ -278,7 +278,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
@@ -318,7 +318,7 @@
             "segments": [
                 {
                     "start": 25,
-                    "end": 51,
+                    "end": 54,
                     "type": "FULL"
                 }
             ],
diff --git a/samples/generated/v1beta1/system_policy_v1_beta1.get_system_policy.js b/samples/generated/v1beta1/system_policy_v1_beta1.get_system_policy.js
@@ -23,6 +23,9 @@
 function main(name) {
   // [START binaryauthorization_v1beta1_generated_SystemPolicyV1Beta1_GetSystemPolicy_async]
   /**
+   * This snippet has been automatically generated and should be regarded as a code template only.
+   * It will require modifications to work.
+   * It may require correct/in-range values for request initialization.
    * TODO(developer): Uncomment these variables before running the sample.
    */
   /**
diff --git a/src/v1/binauthz_management_service_v1_client.ts b/src/v1/binauthz_management_service_v1_client.ts
@@ -28,7 +28,6 @@ import {
 } from 'google-gax';
 
 import {Transform} from 'stream';
-import {RequestType} from 'google-gax/build/src/apitypes';
 import * as protos from '../../protos/protos';
 import jsonProtos = require('../../protos/protos.json');
 /**
@@ -273,7 +272,8 @@ export class BinauthzManagementServiceV1Client {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
@@ -1087,7 +1087,7 @@ export class BinauthzManagementServiceV1Client {
     const callSettings = defaultCallSettings.merge(options);
     this.initialize();
     return this.descriptors.page.listAttestors.createStream(
-      this.innerApiCalls.listAttestors as gax.GaxCall,
+      this.innerApiCalls.listAttestors as GaxCall,
       request,
       callSettings
     );
@@ -1139,7 +1139,7 @@ export class BinauthzManagementServiceV1Client {
     this.initialize();
     return this.descriptors.page.listAttestors.asyncIterate(
       this.innerApiCalls['listAttestors'] as GaxCall,
-      request as unknown as RequestType,
+      request as {},
       callSettings
     ) as AsyncIterable<protos.google.cloud.binaryauthorization.v1.IAttestor>;
   }
diff --git a/src/v1/system_policy_v1_client.ts b/src/v1/system_policy_v1_client.ts
@@ -238,7 +238,8 @@ export class SystemPolicyV1Client {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
diff --git a/src/v1/validation_helper_v1_client.ts b/src/v1/validation_helper_v1_client.ts
@@ -238,7 +238,8 @@ export class ValidationHelperV1Client {
       const apiCall = this._gaxModule.createApiCall(
         callPromise,
         this._defaults[methodName],
-        descriptor
+        descriptor,
+        this._opts.fallback
       );
 
       this.innerApiCalls[methodName] = apiCall;
diff --git a/src/v1beta1/binauthz_management_service_v1_beta1_client.ts b/src/v1beta1/binauthz_management_service_v1_beta1_client.ts
diff --git a/src/v1beta1/system_policy_v1_beta1_client.ts b/src/v1beta1/system_policy_v1_beta1_client.ts
diff --git a/test/gapic_binauthz_management_service_v1_beta1_v1beta1.ts b/test/gapic_binauthz_management_service_v1_beta1_v1beta1.ts
diff --git a/test/gapic_binauthz_management_service_v1_v1.ts b/test/gapic_binauthz_management_service_v1_v1.ts
diff --git a/test/gapic_system_policy_v1_beta1_v1beta1.ts b/test/gapic_system_policy_v1_beta1_v1beta1.ts
diff --git a/test/gapic_system_policy_v1_v1.ts b/test/gapic_system_policy_v1_v1.ts
diff --git a/test/gapic_validation_helper_v1_v1.ts b/test/gapic_validation_helper_v1_v1.ts

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`"segments": [`
`23`	`23`	`{`
`24`	`24`	`"start": 25,`
`25`		`- "end": 51,`
	`25`	`+ "end": 54,`
`26`	`26`	`"type": "FULL"`
`27`	`27`	`}`
`28`	`28`	`],`
`@@ -62,7 +62,7 @@`
`62`	`62`	`"segments": [`
`63`	`63`	`{`
`64`	`64`	`"start": 25,`
`65`		`- "end": 52,`
	`65`	`+ "end": 55,`
`66`	`66`	`"type": "FULL"`
`67`	`67`	`}`
`68`	`68`	`],`
`@@ -102,7 +102,7 @@`
`102`	`102`	`"segments": [`
`103`	`103`	`{`
`104`	`104`	`"start": 25,`
`105`		`- "end": 62,`
	`105`	`+ "end": 65,`
`106`	`106`	`"type": "FULL"`
`107`	`107`	`}`
`108`	`108`	`],`
`@@ -150,7 +150,7 @@`
`150`	`150`	`"segments": [`
`151`	`151`	`{`
`152`	`152`	`"start": 25,`
`153`		`- "end": 51,`
	`153`	`+ "end": 54,`
`154`	`154`	`"type": "FULL"`
`155`	`155`	`}`
`156`	`156`	`],`
`@@ -190,7 +190,7 @@`
`190`	`190`	`"segments": [`
`191`	`191`	`{`
`192`	`192`	`"start": 25,`
`193`		`- "end": 52,`
	`193`	`+ "end": 55,`
`194`	`194`	`"type": "FULL"`
`195`	`195`	`}`
`196`	`196`	`],`
`@@ -230,7 +230,7 @@`
`230`	`230`	`"segments": [`
`231`	`231`	`{`
`232`	`232`	`"start": 25,`
`233`		`- "end": 64,`
	`233`	`+ "end": 67,`
`234`	`234`	`"type": "FULL"`
`235`	`235`	`}`
`236`	`236`	`],`
`@@ -278,7 +278,7 @@`
`278`	`278`	`"segments": [`
`279`	`279`	`{`
`280`	`280`	`"start": 25,`
`281`		`- "end": 51,`
	`281`	`+ "end": 54,`
`282`	`282`	`"type": "FULL"`
`283`	`283`	`}`
`284`	`284`	`],`
`@@ -318,7 +318,7 @@`
`318`	`318`	`"segments": [`
`319`	`319`	`{`
`320`	`320`	`"start": 25,`
`321`		`- "end": 51,`
	`321`	`+ "end": 54,`
`322`	`322`	`"type": "FULL"`
`323`	`323`	`}`
`324`	`324`	`],`
`@@ -358,7 +358,7 @@`
`358`	`358`	`"segments": [`
`359`	`359`	`{`
`360`	`360`	`"start": 25,`
`361`		`- "end": 72,`
	`361`	`+ "end": 75,`
`362`	`362`	`"type": "FULL"`
`363`	`363`	`}`
`364`	`364`	`],`