Skip to content

chore: migrate java tests#3227

Merged
JoeWang1127 merged 17 commits intomainfrom
chore/migrate-java-tests
Sep 24, 2024
Merged

chore: migrate java tests#3227
JoeWang1127 merged 17 commits intomainfrom
chore/migrate-java-tests

Conversation

@JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Sep 23, 2024 •
edited
Loading

In this PR:

  • Migrate test_language_java.py and test resources from synthtool.
  • Remove synthtool installation step in CI.
  • Remove unused methods in java.py.
  • Refactor code to align with the current coding style.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 23, 2024
JoeWang1127
JoeWang1127 commented Sep 24, 2024
View reviewed changes
...ary_generation/owlbot/templates/java_library/.github/workflows/update_generation_config.yaml
- cron: '0 2 * * *'
workflow_dispatch:

{% raw %}
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to render ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}, use raw to ignore the variable.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 24, 2024 12:37
@snippet-bot
Copy link

snippet-bot bot commented Sep 24, 2024

Here is the summary of possible violations 😱

Details

There are 3 possible violations for not having product prefix.
There are format violations for 3 region tags.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@JoeWang1127 JoeWang1127 mentioned this pull request Sep 24, 2024
Merged
blakeli0
blakeli0 reviewed Sep 24, 2024
View reviewed changes
library_generation/test/resources/test-owlbot/testdata/multi-config.yaml Outdated
Copy link
Contributor

@blakeli0 blakeli0 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file still used in unit tests? Same question for all other test files like sponge-log-golden.xml. I don't see them being used so they should've probably be removed from synthtool long time ago. Can we only keep the ones used in unit tests?

Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion.

I removed unused test resources.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit d059530 into main Sep 24, 2024
@JoeWang1127 JoeWang1127 deleted the chore/migrate-java-tests branch September 24, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeWang1127 @blakeli0