Merged
Conversation
Updating cloud rad generation to support [java-shared-config/pull/344](googleapis/java-shared-config#344) updates and removing inclusion of README as we're not currently supporting this feature yet
BenWhitehead
approved these changes
Nov 2, 2021
lesv
approved these changes
Nov 8, 2021
suztomo
reviewed
Jun 7, 2022
| cp README.md target/docfx-yml/index.md | ||
| # copy CHANGELOG to docfx-yml dir and rename history.md | ||
| # cloud RAD generation | ||
| mvn clean javadoc:aggregate -B -q -P docFX |
Member
There was a problem hiding this comment.
(Not related to this commit) Line 34 has
# compile all packages
mvn clean install -B -q -DskipTests=true
The output is cleaned up at line 40 (mvn clean ...). Do we really need line 34?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating cloud rad generation to support java-shared-config/pull/344 updates and removing inclusion of README as we're not currently supporting this feature yet
Won't merge until shared-config update has been released