Skip to content

Conversation

@joanlopez
Copy link
Contributor

What?

  • Fixes the import path for testutils/grpcservice:
    • Note: "internal" import is allowed because the module name also "belongs" to k6
  • Removes the call to rand.Seed, which is no longer needed since Go 1.20, I think.

Why?

To keep the examples, and dependant services, healthy.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@joanlopez joanlopez self-assigned this May 21, 2025
@joanlopez joanlopez requested a review from a team as a code owner May 21, 2025 13:33
@joanlopez joanlopez requested review from ankur22 and mstoykov and removed request for a team May 21, 2025 13:33
@joanlopez joanlopez merged commit fb3777b into master May 22, 2025
30 of 32 checks passed
@joanlopez joanlopez deleted the grpc_server branch May 22, 2025 09:47
@joanlopez joanlopez added this to the v1.1.0 milestone Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants