Skip to content

Print deps string as in v1.3.0 - Fixes 5327 #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mstoykov merged 1 commit into from
Oct 24, 2025
Merged

Print deps string as in v1.3.0 - Fixes 5327 #5332

mstoykov merged 1 commit into from
Oct 24, 2025

Conversation

@mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Oct 23, 2025

What?

Fixes #5327

Why?

It does look better printing the dependencies in that way.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v1.4.0 milestone Oct 23, 2025
@mstoykov mstoykov requested a review from a team as a code owner October 23, 2025 10:54
@mstoykov mstoykov requested review from codebien and oleiade and removed request for a team October 23, 2025 10:54
@mstoykov mstoykov added the area: Auto Extension Resolution Previously known as binary provisioning. label Oct 23, 2025
@mstoykov mstoykov temporarily deployed to azure-trusted-signing October 23, 2025 11:00 — with GitHub Actions Inactive
@mstoykov mstoykov temporarily deployed to azure-trusted-signing October 23, 2025 11:03 — with GitHub Actions Inactive
@mstoykov mstoykov requested a review from pablochacin October 24, 2025 08:10
pablochacin
pablochacin approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstoykov mstoykov merged commit 0f83677 into master Oct 24, 2025
38 of 40 checks passed
@mstoykov mstoykov deleted the fix5327 branch October 24, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebien codebien codebien approved these changes

@oleiade oleiade Awaiting requested review from oleiade oleiade is a code owner automatically assigned from grafana/k6-core

+1 more reviewer

@pablochacin pablochacin pablochacin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: Auto Extension Resolution Previously known as binary provisioning.

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

k6 automatic dependency resolution is reporting constrains as <nil>

3 participants

@mstoykov @pablochacin @codebien