Skip to content

Commit fe4a6e8

Browse files
hakimelhakimel
committed
fix last slide not triggering slidechange in scroll view (closes #3715)
1 parent 5a275f2 commit fe4a6e8

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

‎dist/reveal.esm.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/reveal.esm.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/reveal.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/reveal.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎js/controllers/scrollview.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,10 @@ export default class ScrollView {
449449
rangeStart = trigger.range[1];
450450
} );
451451

452+
// Ensure the last trigger extends to the end of the page, otherwise
453+
// rounding errors can cause the last trigger to end at 0.999999...
454+
this.slideTriggers[this.slideTriggers.length - 1].range[1] = 1;
455+
452456
}
453457

454458
/**

0 commit comments

Comments
 (0)