Remove two redundant if-checks.

atombrella · atombrella · commit 380abe2b1643 · 2025-11-22T10:13:05.000+01:00
These were found with the nilness checker.

Signed-off-by: Mads Jensen &lt;atombrella@users.noreply.github.com&gt;
diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go
@@ -227,13 +227,10 @@ func (c *ChartDownloader) DownloadToCache(ref, version string) (string, *provena
 	// Check the cache for the file
 	digest, err := hex.DecodeString(digestString)
 	if err != nil {
-		return "", nil, err
+		return "", nil, fmt.Errorf("unable to decode digest: %w", err)
 	}
 	var digest32 [32]byte
 	copy(digest32[:], digest)
-	if err != nil {
-		return "", nil, fmt.Errorf("unable to decode digest: %w", err)
-	}
 
 	var pth string
 	// only fetch from the cache if we have a digest
diff --git a/pkg/repo/v1/index_test.go b/pkg/repo/v1/index_test.go
@@ -708,9 +708,7 @@ func TestLoadIndex_DuplicateChartDeps(t *testing.T) {
 			}
 			cvs := idx.Entries["nginx"]
 			if cvs == nil {
-				if err != nil {
-					t.Error("expected one chart version not to be filtered out")
-				}
+				t.Error("expected one chart version not to be filtered out")
 			}
 			for _, v := range cvs {
 				if v.Name == "alpine" {

Original file line number	Diff line number	Diff line change
`@@ -708,9 +708,7 @@ func TestLoadIndex_DuplicateChartDeps(t *testing.T) {`
`708`	`708`	`}`
`709`	`709`	`cvs := idx.Entries["nginx"]`
`710`	`710`	`if cvs == nil {`
`711`		`- if err != nil {`
`712`		`- t.Error("expected one chart version not to be filtered out")`
`713`		`- }`
	`711`	`+ t.Error("expected one chart version not to be filtered out")`
`714`	`712`	`}`
`715`	`713`	`for _, v := range cvs {`
`716`	`714`	`if v.Name == "alpine" {`