Deal with golint warning with private executeShutdownFunc

benoittgt · benoittgt · commit 45c5f3aaca1a · 2025-11-27T08:49:18.000+01:00
```
  Error: pkg/action/release_testing.go:60:57: unexported-return: exported method Run returns unexported type action.executeShutdownFunc, which can be annoying to use (revive)
  func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {

```

Signed-off-by: Benoit Tigeot &lt;benoit.tigeot@lifen.fr&gt;
diff --git a/pkg/action/hooks.go b/pkg/action/hooks.go
@@ -46,14 +46,14 @@ func (cfg *Configuration) execHook(rl *release.Release, hook release.HookEvent,
 	return shutdown()
 }
 
-type executeShutdownFunc = func() error
+type ExecuteShutdownFunc = func() error
 
 func shutdownNoOp() error {
 	return nil
 }
 
 // execHookWithDelayedShutdown executes all of the hooks for the given hook event and returns a shutdownHook function to trigger deletions after doing other things like e.g. retrieving logs.
-func (cfg *Configuration) execHookWithDelayedShutdown(rl *release.Release, hook release.HookEvent, waitStrategy kube.WaitStrategy, timeout time.Duration, serverSideApply bool) (executeShutdownFunc, error) {
+func (cfg *Configuration) execHookWithDelayedShutdown(rl *release.Release, hook release.HookEvent, waitStrategy kube.WaitStrategy, timeout time.Duration, serverSideApply bool) (ExecuteShutdownFunc, error) {
 	executingHooks := []*release.Hook{}
 
 	for _, h := range rl.Hooks {
diff --git a/pkg/action/release_testing.go b/pkg/action/release_testing.go
@@ -57,7 +57,7 @@ func NewReleaseTesting(cfg *Configuration) *ReleaseTesting {
 }
 
 // Run executes 'helm test' against the given release.
-func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {
+func (r *ReleaseTesting) Run(name string) (ri.Releaser, ExecuteShutdownFunc, error) {
 	if err := r.cfg.KubeClient.IsReachable(); err != nil {
 		return nil, shutdownNoOp, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -46,14 +46,14 @@ func (cfg Configuration) execHook(rl release.Release, hook release.HookEvent,`
`46`	`46`	`return shutdown()`
`47`	`47`	`}`
`48`	`48`
`49`		`-type executeShutdownFunc = func() error`
	`49`	`+type ExecuteShutdownFunc = func() error`
`50`	`50`
`51`	`51`	`func shutdownNoOp() error {`
`52`	`52`	`return nil`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`// execHookWithDelayedShutdown executes all of the hooks for the given hook event and returns a shutdownHook function to trigger deletions after doing other things like e.g. retrieving logs.`
`56`		`-func (cfg Configuration) execHookWithDelayedShutdown(rl release.Release, hook release.HookEvent, waitStrategy kube.WaitStrategy, timeout time.Duration, serverSideApply bool) (executeShutdownFunc, error) {`
	`56`	`+func (cfg Configuration) execHookWithDelayedShutdown(rl release.Release, hook release.HookEvent, waitStrategy kube.WaitStrategy, timeout time.Duration, serverSideApply bool) (ExecuteShutdownFunc, error) {`
`57`	`57`	`executingHooks := []*release.Hook{}`
`58`	`58`
`59`	`59`	`for _, h := range rl.Hooks {`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func NewReleaseTesting(cfg Configuration) ReleaseTesting {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`// Run executes 'helm test' against the given release.`
`60`		`-func (r *ReleaseTesting) Run(name string) (ri.Releaser, executeShutdownFunc, error) {`
	`60`	`+func (r *ReleaseTesting) Run(name string) (ri.Releaser, ExecuteShutdownFunc, error) {`
`61`	`61`	`if err := r.cfg.KubeClient.IsReachable(); err != nil {`
`62`	`62`	`return nil, shutdownNoOp, err`
`63`	`63`	`}`