Skip to content

Add none variant to XREye#641

Merged
NellWaliczek merged 1 commit intoimmersive-web:masterfrom
Manishearth:eye-none
May 14, 2019
Merged

Add none variant to XREye#641
NellWaliczek merged 1 commit intoimmersive-web:masterfrom
Manishearth:eye-none

Conversation

@Manishearth
Copy link
Copy Markdown
Contributor

@Manishearth Manishearth commented May 14, 2019

Fixes #620

NellWaliczek
NellWaliczek approved these changes May 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NellWaliczek NellWaliczek merged commit 7278bfe into immersive-web:master May 14, 2019
@AdaRoseCannon AdaRoseCannon added ed:explainer Include in newsletter, explainer change ed:feature Include in newsletter, adds a feature ed:spec Include in newsletter, spec change labels Jun 17, 2019
@Manishearth Manishearth deleted the eye-none branch August 13, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NellWaliczek NellWaliczek NellWaliczek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ed:explainer Include in newsletter, explainer change ed:feature Include in newsletter, adds a feature ed:spec Include in newsletter, spec change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

We shouldn't default XREyes to left when they're unknown

3 participants

@Manishearth @NellWaliczek @AdaRoseCannon