Skip to content

Update KotlinLateinitFilter for Kotlin 1.5#1166

Merged
marchof merged 3 commits intomasterfrom
KotlinLateinitFilter
Mar 21, 2021
Merged

Update KotlinLateinitFilter for Kotlin 1.5#1166
marchof merged 3 commits intomasterfrom
KotlinLateinitFilter

Conversation

@Godin
Copy link
Member

@Godin Godin commented Mar 20, 2021

Currently execution of

mvn clean package -Dkotlin.version=1.5.0-M1

leads to

Failed tests:
  execute_assertions_in_comments(org.jacoco.core.test.validation.kotlin.KotlinLateinitTest): Instructions (KotlinLateinitTarget.kt:26) expected:<[FUL]LY_COVERED> but was:<[PART]LY_COVERED>

What seems to be related to the following change in Kotlin compiler - JetBrains/kotlin@7c95781

@Godin Godin added this to the 0.8.7 milestone Mar 20, 2021
@Godin Godin self-assigned this Mar 20, 2021
@Godin Godin force-pushed the KotlinLateinitFilter branch from c0d283b to 70a3e5b Compare March 20, 2021 16:11
@Godin Godin marked this pull request as ready for review March 21, 2021 13:33
@Godin Godin requested a review from marchof March 21, 2021 13:33
@marchof
Copy link
Member

marchof commented Mar 21, 2021 •
edited
Loading 

m.visitInsn(Opcodes.ACONST_NULL);
m.visitInsn(Opcodes.ATHROW);

Oh shit, I hope for Kotlin the JVM will never tighten its verifier 😱

@marchof marchof merged commit 5bbe202 into master Mar 21, 2021
@marchof marchof deleted the KotlinLateinitFilter branch March 21, 2021 19:34
@Godin
Copy link
Member Author

Godin commented Mar 22, 2021

@marchof what do you mean? according to https://docs.oracle.com/javase/specs/jvms/se16/html/jvms-6.html#jvms-6.5.athrow

If objectref is null, athrow throws a NullPointerException instead of objectref.

@marchof
Copy link
Member

marchof commented Mar 22, 2021

Sure... I mean something like SonarQube for bytecode 😅

ACONST_NULL
ATHROW
^ Warning: This will always result in a NPE

This was referenced May 4, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels

component: core.filters language: Kotlin type: enhancement

Projects

Current work items
Archived in project
Filtering
Status: Done

Milestone

0.8.7

Development

Successfully merging this pull request may close these issues.

2 participants

@Godin @marchof