Selector: reduce size, simplify setDocument - #4462
Merged
Merged
Conversation
mgol
force-pushed
the
selector-size-opt
branch
from
August 19, 2019 16:04
9dd6915 to
91652ed
Compare
Member
Author
|
|
mgol
force-pushed
the
selector-size-opt
branch
6 times, most recently
from
August 22, 2019 00:13
fd30507 to
321f3fb
Compare
timmywil
approved these changes
Aug 26, 2019
timmywil
left a comment
Member
There was a problem hiding this comment.
Checked this locally and it looks good. The chrome-debug task was broken, but I'll have a PR to fix it.
With new selector code doing less convoluted support tests, it was possible to extract a lot of logic out of setDocument & also reduce size. This commit also backports jquery/sizzle#439 that was reverted by mistake during a switch from JSHint + JSCS to ESLint. Ref jquery/sizzle#442 Ref jquery/sizzle#439
mgol
force-pushed
the
selector-size-opt
branch
from
August 26, 2019 17:10
321f3fb to
ae84055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With new selector code doing less convoluted support tests, it was possible
to extract a lot of logic out of setDocument & also reduce size.
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com