-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Expando Collision Handling #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, so collisions become less likely. Also added jQuery version to instantly differentiate separate versions of jQuery (a common use case for noConflict, etc, when two jQuery instances are on the page)
…umber. removed nonAlphanumeric stuff.
Sorry, for late answer. PS: I don't think it is bad to leave more commits if you are adding changes. Reclosing/reopening the same pull req. splits the same discussion. |
How do I do a pull request of a new patch without closing one and opening another? |
If you made pull req. from your master (and you did), then successively pushed commits to that branch will be auto-added to the req. Hope I was clear. |
Awesome, I was unaware of that feature. |
Indeed! This pull request system is a bless. :) EDIT: Also, when you begin to open more pull req., then you can for each create a separate branch, so commits will not be mixed, but req. will still be updated.. |
As for the change that you suggest, is there anything invalid about |
With current |
…c' versions inside of jQuery.fn.jquery
I went ahead and updated it. Thanks for the fix. |
This is for ticket #6842. |
Committed. |
Updated this pull request with the feedback from everyone.