Skip to content

install script: Update minimum shell count check to include Nushell #4813

Description

@matheus-pacifico

Checklist

  • I have read through the manual page (man fzf)
  • I have searched through the existing issues
  • For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.73.1 (ce4bef7)

OS

  • Linux
  • macOS
  • Windows
  • Etc.

Shell

  • bash
  • zsh
  • fish
  • nushell

Problem / Steps to reproduce

The shell configuration update check still assumes there are only 3 supported shells (bash, zsh, and fish). Since nushell support was added, the condition is outdated.

if [[ ${#shells} -lt 3 ]]; then
  echo "No shell configuration to be updated."
  exit 0
fi

Proposed Solution

Update the count from 3 to 4

if [[ ${#shells} -lt 4 ]]; then
  echo "No shell configuration to be updated."
  exit 0
fi

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions