You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For bug reports, I have checked if the bug is reproducible in the latest version of fzf
Output of fzf --version
0.73.1 (Homebrew)
OS
Linux
macOS
Windows
Etc.
Shell
bash
zsh
fish
Problem / Steps to reproduce
Note
No AI was used! I noticed you closed contributions due to an influx of low-effort PRs, so I put in the time to keep the code minimal and fully understand the changes. I love your work, please keep going!
One day, I encountered jittering when scrolling up/down on my macOS trackpad in fzf. I realized it was because the horizontal scroll component is factored in, so if you scroll 45° up and right or 45° down and left, the scroll counteracts itself! I propose that horizontal mouse wheel events should not count as vertical scrolling.
Reproducing
Use a terminal that supports horizontal scrolling (e.g., Ghostty, Alacritty, Kitty, etc.).
Scroll horizontally in fzf.
Scrolling left should scroll upwards. Scrolling right should scroll downwards.
The Fix
I believe the issue has to do with lines 908-915 of light.go. The logic for SGR mouse wheel events is as follows. Is this intended?
Checklist
man fzf)Output of
fzf --version0.73.1 (Homebrew)
OS
Shell
Problem / Steps to reproduce
Note
No AI was used! I noticed you closed contributions due to an influx of low-effort PRs, so I put in the time to keep the code minimal and fully understand the changes. I love your work, please keep going!
One day, I encountered jittering when scrolling up/down on my macOS trackpad in fzf. I realized it was because the horizontal scroll component is factored in, so if you scroll 45° up and right or 45° down and left, the scroll counteracts itself! I propose that horizontal mouse wheel events should not count as vertical scrolling.
Reproducing
fzf.The Fix
I believe the issue has to do with lines 908-915 of light.go. The logic for SGR mouse wheel events is as follows. Is this intended?
I made a branch with the following changes:
I just made horizontal scrolling a no-op. In the future, we can support proper horizontal scrolling (#4824).