Prevent nushell source contamination in install shell loop#4812
Merged
Conversation
11 tasks
Copilot
AI
changed the title
[WIP] Fix install script key-bindings and completions in Fish config
Prevent nushell source contamination in install shell loop
May 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reorders the nushell skip in the install script's shell loop so that nushell is bypassed before the fish-shared fzf_completion / fzf_key_bindings variables are assigned. This prevents stale nushell-derived values (e.g., paths ending in .nushell) from leaking into fish partial-enable flows that reuse those variables outside the loop.
Changes:
- Move
[[ $shell == nushell ]] && continueabove the assignments tofzf_completionandfzf_key_bindingsininstall.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both
fishandnushellare detected, the install loop could carry over previously assignedfzf_completion/fzf_key_bindingsvalues and write a nushell source line into fish config in partial-enable flows (key bindings only or completion only).Root cause
nushellwas skipped after shell-specific source variables were assigned, allowing stale values to leak into later fish update logic.Change
installsonushellis skipped immediately at loop entry, before assigning:fzf_completionfzf_key_bindingsCode snippet