fish: Make CTRL-R work on empty/invalid $fish_color{normal,comment}#4831
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Fish shell Ctrl-R history search failures caused by invalid/empty $fish_color_comment and/or $fish_color_normal, which can currently result in set_color errors and a blank fzf list (as reported in #4767 and #4830).
Changes:
- Updates the Fish
Ctrl-Rhistory command to fall back toset_color normalwhen$fish_color_commentis invalid/empty, avoidingset_colorerrors during--show-timeformatting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4767
Fix #4830
Contribution Policy
We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.
All contributions are expected to demonstrate:
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.
Acknowledgement